feat: warn user when unsupported 'delta --navigate' flag is used #5139
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5136
The Issue
Users attempting to use
delta --navigatewere finding that navigation keys (n/N) were unresponsive. This is becauselazygitreads the pager's stdout via a PTY but does not forwardstdinto the subprocess, making interactive features architecturally impossible in the current view.The Fix
I added a startup check in
onInitialViewsCreation(inpkg/gui/layout.go). If the user's config containsdeltaand--navigate, a modal dialog now appears explaining that this feature is not supported and advising them to remove the flag. The warning is also logged to the debug log for reference.Why This Happens
Lazygit captures pager output via a PTY to display it in the TUI, but keyboard input goes through lazygit's own keybinding system rather than being forwarded to the subprocess. This architectural design means interactive pager features cannot work as intended.
Validation
I reproduced the issue with a local config and verified the dialog appears on startup:
Please check if the PR fulfills these requirements
go generate ./...)