fix: add setSerializers and defaultSerializers to TS types
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to upgrade due to the changes in #92. That DefinitelyTyped/DefinitelyTyped#39243 was released is pretty weird to me, it's super breaking... Anyway, the changes here looks great 👍 |
thymikee
changed the title
setSerializers and defaultSerializers to TS types
|
Is it possible for TS to override the interface to be compatible with the older version of |
|
I don't know... IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing TS types for
setSerializersanddefaultSerializerscc @SimenB can you test that?