[proposal] use globs instead of regex in config

[boujeepossum]

Regexes are very hard to get right when you're setting up a new project, especially when they're inside a .json file.

i was thinking maybe using something like https://github.com/fitzgen/glob-to-regexp

regex config can also be preserved, e.g.:

{
  "jest": {
    "testPathIgnorePatterns": ["**/__tests__/**/*.js"],
    "testPathPattern": "__tests__/*-test.js*"
}

or

{
  "jest": {
    "testPathPatternRegex": ".*\\.js"
  }
}

[cpojer]

An overhaul of the entire config system was planned. I would definitely like to preserve the ability to use regex however, as that is likely what most Facebook projects will want to continue to use.

Here are some parts to this:

• Design a new, simpler config system
• Convert old configs through an adapter. We can install and use that by default, warn for one major version and then drop it in the next.
• Make testPathPattern actually a pattern and not a directory pattern :D This has been a long standing feature request.
• Allow the use of both regex and patterns.

What do you think about re-thinking Jest's config and also possibly the CLI options? :)

[boujeepossum]

that would be a nice mini project to work on :)

[jsynowiec]

Any news regarding glob patterns for testPath? Most other tools that we usually use rely on glob patterns for specifying input files so it may be more natural and easier to use globs instead of regex in the package.json file.

[boujeepossum]

it's still on our plan. First we need to make sure there is no performance regression when using globs and then we'll probably keep both regxeps and globs in jest configuration :)

[develar]

👍 RegExp is not user-friendly way to specify --testPathPattern or --testNamePattern AVA supports glob and it makes migration not so easy (compare glob ignore ! and http://stackoverflow.com/questions/2078915/a-regular-expression-to-exclude-a-word-string)

[develar]

For --testNamePattern AVA uses even more simplier way — https://www.npmjs.com/package/matcher

[pksjce]

I wanted to take this up. I think I could add glob-to-regexp in jest-config's normalize.
But, in jest-config, npm run test is broken ie fails with syntax error in master. Have I missed a step here?

[cpojer]

@pksjce you should run jest on the top level, like npm test -- jest-config or jest config – it reads pretty nicely if you have Jest installed globally.

[cpojer]

I'm curious to see what you come up with without breaking changes and significantly making configuration in Jest harder.

[develar]

@pksjce glob-to-regexp doesn't work correctly and should be not used. No one want poor partially (e.g. compared to AVA) glob — minimatch syntax should be supported, especially including ignore support !.

[cpojer]

@develar I agree it would simplify our configuration but you have to consider it would be a major breaking change for Jest and we have a ton of existing codebases that use the old system, both inside of FB and outside. This needs to be done carefully.

[pksjce]

@develar , @cpojer - Thanks for the quick response.
I am definitely not an expert on glob syntax.
I only went ahead with the idea of not breaking existing regexp and supporting glob too. Normalizing with glob-to-regex in jest-config seemed feasible to me as the jest-cli and other packages would be effectively decoupled from this config change.
@develar - What are the issues that are associated with glob-to-regex?

[develar]

No need to break to fix this issue except one minor case.

• Deprecate testRegex and testPathIgnorePatterns. Introduce testGlob. For reference: in Ava named as --source (-S). So, user will be able to use glob.

• jest CLI signature node_modules/.bin/jest TestPathPattern remains untouched to keep backward compatibility. Decision when to break compatibility up to project authors. For user it is ok to use flag to provide test glob.

update: testGlob should be or single pattern, or array (minimatch-all).