chore: add typechecks for tests of expect-utils and jest-circus
#13387
Conversation
| @@ -5,7 +5,7 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import {Circus} from '@jest/types'; | |||
| import type {Circus} from '@jest/types'; | |||
There was a problem hiding this comment.
TS caught this. Good. This means that __mocks__ directory is also covered.
| @@ -46,16 +46,19 @@ describe('isError', () => { | |||
| }); | |||
|
|
|||
| it('should detect errors from another context', () => { | |||
| testErrorFromDifferentContext(win => new win.Error()); | |||
| testErrorFromDifferentContext( | |||
| win => new (win as typeof globalThis).Error(), | |||
There was a problem hiding this comment.
Error does not exist on type Window, but all works with typeof globalThis. Is fine? Or?
| @@ -3,5 +3,6 @@ | |||
| "compilerOptions": { | |||
| "rootDir": "../" | |||
| }, | |||
| "include": ["../**/*"] | |||
| "include": ["../**/*"], | |||
| "references": [{"path": "../../../jest-expect"}] | |||
There was a problem hiding this comment.
Needed to include this declaration:
There was a problem hiding this comment.
Shouldn't types be built before type testing tests? I.e., no need for a reference?
There was a problem hiding this comment.
In this case tsc needs the reference for augmentation. The packages/jest-circus/tsconfig.json has this reference, but the packages/jest-circus/src/__tests__/tscongo.json is extending the root config. That’s why the reference is missing.
There was a problem hiding this comment.
Reference is only so the build is in the correct order right? I don't understand why the test builds needs a specific order
There was a problem hiding this comment.
I also thought so, but typecheck was not passing. Just removed references and now it is passing. Not sure why? ;D Let’s see what CI thinks.
There was a problem hiding this comment.
See the error in CI. With references it goes away. I did not know that, just guessed that reference might work. Adding a .d.ts also works, but reference seemed to be cleaner.
| @@ -3,5 +3,6 @@ | |||
| "compilerOptions": { | |||
| "rootDir": "../" | |||
| }, | |||
| "include": ["../**/*"] | |||
| "include": ["../**/*"], | |||
| "references": [{"path": "../../"}] | |||
There was a problem hiding this comment.
To typecheck test files, tsc runs with -b flag. Also it gets files in __tests__ and src directories still in TypeScript, not the compiled ones from build. It has to build them (in memory). Logically src has to be build first, so pointing references to packages/jest-circus/tsconfig.json makes sense.
mrazauskas
deleted the
chore-typechecks-for-expect-utils-and-jest-circus
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixed types and added typechecks for tests of
expect-utilsandjest-circuspackages.Test plan
Green CI.