Reset context between test functions#3506
Merged
cpojer merged 1 commit intojestjs:masterfrom May 11, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3506 +/- ##
=======================================
Coverage 62.28% 62.28%
=======================================
Files 181 181
Lines 6700 6700
Branches 5 5
=======================================
Hits 4173 4173
Misses 2525 2525
Partials 2 2
Continue to review full report at Codecov.
|
boujeepossum
added a commit
to boujeepossum/jest
that referenced
this pull request
Jun 21, 2017
This reverts commit a9a322f.
This was referenced Jul 4, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
thiscontext we're passing inbefore/after(although herethisis undefined, and I didn't even try to investigate why) andit/testfunctions is preserved across consequenttestruns, which makes it confusing to use (see #3505).As a workaround I propose passing empty object as a context for each function. This way we can still use
thisintestbut it will be unique for each test function.Fixes #3505.
Test plan
I'll add an integration test later, after we agree this is the right solution.