Skip to content

Added hints in errors message on possible causes of 403 status for docker push #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

fluxxBot
Copy link
Contributor

@fluxxBot fluxxBot commented Apr 8, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This change is done to address the issue where docker push command fails abruptly when a Xray policy in force (blocks any request on unscanned artifacts).

Below command is divided into two parts
jf docker push --build-name <name> --build-number <number>

  • push docker image
  • collect docker build info

Docker push is successful but build info collection fails with 403 error while collecting docker image details when a Xray policy is in force. This PR aims to educate users with possible reasons for the failure since exact failure reason is not available as Head HTTP method is used to check image availability.

Screenshot 2025-04-10 at 2 04 09 PM

Copy link
Contributor

@bhanurp bhanurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure error is formatted into multiple lines since it is a long message

@fluxxBot fluxxBot requested a review from bhanurp April 9, 2025 19:47
@bhanurp bhanurp changed the title Added error notification and causes on 403 docker push Added hints in errors message on possible causes of 403 status for docker push Apr 10, 2025
@bhanurp bhanurp added the improvement Automatically generated release notes label Apr 10, 2025
@fluxxBot fluxxBot requested a review from bhanurp April 10, 2025 07:08
@fluxxBot fluxxBot merged commit f34f5fe into jfrog:dev Apr 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants