Introduce support for multisource and new source type 'package' #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined in spec and support new source type
agrasth
reviewed
Jun 6, 2025
agrasth
reviewed
Jun 6, 2025
fluxxBot
requested changes
Jun 6, 2025
Co-authored-by: Agrasth Naman <[email protected]>
Co-authored-by: Agrasth Naman <[email protected]>
Co-authored-by: Agrasth Naman <[email protected]>
agrasth
approved these changes
Jun 16, 2025
fluxxBot
requested changes
Jun 16, 2025
| @@ -230,11 +239,9 @@ func ValidateSpec(files []File, isTargetMandatory, isSearchBasedSpec bool) error | |||
| if !isSearchBasedSpec && !isPattern { | |||
| return errorutils.CheckErrorf("spec must include a pattern") | |||
| } | |||
| if isBuild && isBundle { | |||
There was a problem hiding this comment.
why is this condition removed?
There was a problem hiding this comment.
@fluxxBot Because this condition isn't valid anymore. It may be both builds and bundles
fluxxBot
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.