Markdown to DokuWiki - External Images

[randomessence]

Image links using an external URL for the image (github for example) have a : at the start of the URL breaking the code. For an external URL it should not have the first : in this {{:http...

Proof of the issue:

We take this image:

https://raw.githubusercontent.com/adam-p/markdown-here/master/src/common/images/icon48.png

For example, embedded using Markdown:

Here is the code:

![A test image](https://raw.githubusercontent.com/adam-p/markdown-here/master/src/common/images/icon48.png)

Then go here:

http://johnmacfarlane.net/pandoc/try/?text=&from=markdown&to=dokuwiki

Convert the above image code to Dokuwiki Syntax.

Then go use it here:

https://www.softaculous.com/demos/DokuWiki

And use the code in a demo post. the demo uses Hrun

You will get this code, it does not work:

{{:https://raw.githubusercontent.com/adam-p/markdown-here/master/src/common/images/icon48.png| A test image}}

Working code:

{{https://raw.githubusercontent.com/adam-p/markdown-here/master/src/common/images/icon48.png| A test image}}

[jgm]

Pinging @claremacrae, who wrote the DokuWiki writer.

[claremacrae]

From looking at my commit that claimed to implement images - bb83563890cc9e4f65679693 - I definitely didn't handle external URLs. I think I maybe just didn't know it was possible for DoluWiki to pull in external images, so that's good to know about.

[thumphries]

PR submitted. Let me know if you see any mistakes.