Add support for disabling few website features#1597
Conversation
|
Hey @jhaals! What do you think about those changes? For our deployment we need to be able to disable the "one-click" link - thus this PR would also fix me use case :). Best regards |
|
Hey @jhaals! |
jhaals
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay, I have been away on parental leave so these things have been put on hold. I think this make sense, would you or someone else interested in this feature be so kind and change the name of the environment variables to start with YOPASS_ instead of REACT_APP(I should update the other too but that will be breaking).
| - `REACT_APP_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | ||
| - `REACT_APP_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support |
There was a problem hiding this comment.
| - `REACT_APP_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | |
| - `REACT_APP_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support | |
| - `YOPASS_DISABLE_FEATURES_CARDS=1` - Allows disabling Features cards | |
| - `YOPASS_DISABLE_ONE_CLICK_LINK=1` - Allows disabling "One-click link" support |
|
|
|
Thanks 👏 |
|
@Neverous just a small think left to fix. |
- Toggle for Features cards - Toggle for "One-click link"
|
I don't think its waiting for anything from me, its ready to be merged @jhaals ? |
This adds build time toggles for disabling: