Skip to content

Feature: env var config#2143

Merged
jhaals merged 4 commits intojhaals:masterfrom
24367dfa:feat/env-var-config
Mar 12, 2025
Merged

Feature: env var config#2143
jhaals merged 4 commits intojhaals:masterfrom
24367dfa:feat/env-var-config

Conversation

@24367dfa
Copy link
Copy Markdown
Contributor

@24367dfa 24367dfa commented Feb 9, 2024

This PR adds:

  • a prefix (yopass) to config variables loaded from env. this might be considered a non breaking change, since it was an undocumented feature before.
  • a docker compose example for configuring yopass using env vars
  • documentation for configuring yopass using env vars to README

closes #2122

@24367dfa
Copy link
Copy Markdown
Contributor Author

@jhaals is there anything i can to to move this PR forward?

Copy link
Copy Markdown
Owner

@jhaals jhaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhaals jhaals merged commit 5eeb070 into jhaals:master Mar 12, 2025
@psalaberria002
Copy link
Copy Markdown

This PR can break yopass instances if they run in Kubernetes. YOPASS_PORT is set by Kubernetes if there is a Service called yopass in the cluster. In my case Kubernetes is injecting YOPASS_PORT=tcp://10.100.11.235:80.

A workaround is to pass --port=1337 directly.

jhaals added a commit that referenced this pull request Apr 5, 2025
This reverts commit 5eeb070, reversing
changes made to 976d7b2.
jhaals added a commit that referenced this pull request Apr 5, 2025
Revert "Merge pull request #2143 from 24367dfa/feat/env-var-config"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for configuring via ENV Vars

3 participants