Skip to content

Add dark mode#2809

Merged
jhaals merged 3 commits intojhaals:masterfrom
abjugard:feature/add_dark_mode
May 19, 2025
Merged

Add dark mode#2809
jhaals merged 3 commits intojhaals:masterfrom
abjugard:feature/add_dark_mode

Conversation

@abjugard
Copy link
Copy Markdown
Contributor

@abjugard abjugard commented May 1, 2025

Really liked your project but felt it needed a dark mode!

Where changes had to be made to the light mode theme I've kept things as close to the original as possible.

I put a toggle to the left of the upload button in the header, and it will auto-select based on the user-agents OS-level dark/light-mode choice.

@jhaals
Copy link
Copy Markdown
Owner

jhaals commented May 13, 2025

Hej @abjugard!

I agree that dark mode would be fantastic, really appreciate your contribution! There seems to be some minor code style issues that need addressing, make sure to run prettier --write to format the files correctly :)

@abjugard abjugard force-pushed the feature/add_dark_mode branch from f16ef61 to cd573c8 Compare May 13, 2025 13:32
@abjugard
Copy link
Copy Markdown
Contributor Author

Ah, sorry about that, all prettified now :)

Let me know if there's anything else that needs changing!

@jhaals
Copy link
Copy Markdown
Owner

jhaals commented May 14, 2025

Looking good but I just realized that a test failed. Probably because the cypress selector changed slightly

@abjugard
Copy link
Copy Markdown
Contributor Author

abjugard commented May 14, 2025

I may not have ran your tests before now 😅

The ModeToggle component is also a button so the cy.get('button') calls weren't specific enough anymore. Changed it to instead call cy.contains('Decrypt secret').

Maybe it should be cy.get('button').contains('Decrypt secret') instead? Chose the former because that's how you were pressing the "Encrypt Message" button.

@abjugard
Copy link
Copy Markdown
Contributor Author

@jhaals What's going on with those Netlify pipelines? 🤔

@jhaals
Copy link
Copy Markdown
Owner

jhaals commented May 19, 2025

@abjugard they just require manual approval to run. Looking great now, thank you so much for this 👏

@jhaals jhaals merged commit 0abafc5 into jhaals:master May 19, 2025
10 of 12 checks passed
TassiloPitrasch pushed a commit to TassiloPitrasch/yopass that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants