Skip to content

fix: Do not display QR code for large secrets#2829

Merged
jhaals merged 1 commit intomasterfrom
jhaals/fix-qr
May 19, 2025
Merged

fix: Do not display QR code for large secrets#2829
jhaals merged 1 commit intomasterfrom
jhaals/fix-qr

Conversation

@jhaals
Copy link
Copy Markdown
Owner

@jhaals jhaals commented May 19, 2025

Will not render QR code above 500 letters.
Fixes #2810

Will not render QR code above 500 letters.
Fixes #2810

Signed-off-by: Johan Haals <johan.haals@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.04%. Comparing base (9af2e37) to head (c2b1993).
Report is 56 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   71.04%   71.04%           
=======================================
  Files           8        8           
  Lines         670      670           
=======================================
  Hits          476      476           
  Misses        163      163           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jhaals jhaals merged commit 6b5a343 into master May 19, 2025
12 of 15 checks passed
@jhaals jhaals deleted the jhaals/fix-qr branch May 19, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Viewing large secrets lead to blank page due to error in QRcode.js

1 participant