Skip to content

Fix multiple UI issues for secret display#3209

Merged
jhaals merged 2 commits intomasterfrom
fix/3159-ui-improvements
Dec 9, 2025
Merged

Fix multiple UI issues for secret display#3209
jhaals merged 2 commits intomasterfrom
fix/3159-ui-improvements

Conversation

@jhaals
Copy link
Copy Markdown
Owner

@jhaals jhaals commented Dec 5, 2025

  • Fix layout to properly position footer at bottom using flexbox
  • Fix QR code display logic to check decrypted data length instead of encrypted secret
  • Hide QR code button completely when secret is too long for QR
  • Add break-words CSS class to prevent text overflow in secret display
  • Increase QR code size from 180 to 250 for better readability
  • Remove trailing newline from index.css

These changes improve the user experience when viewing decrypted secrets, particularly for long messages and QR code generation.

Includes all changes from #3159 contributed by @x1arch

- Fix layout to properly position footer at bottom using flexbox
- Fix QR code display logic to check decrypted data length instead of encrypted secret
- Hide QR code button completely when secret is too long for QR
- Add break-words CSS class to prevent text overflow in secret display
- Increase QR code size from 180 to 250 for better readability
- Remove trailing newline from index.css

These changes improve the user experience when viewing decrypted secrets, particularly for long messages and QR code generation.

Supersedes: fix/3159
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.68%. Comparing base (71bdbff) to head (d126950).
⚠️ Report is 63 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3209   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           8        8           
  Lines         808      808           
=======================================
  Hits          660      660           
  Misses        109      109           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jhaals
Copy link
Copy Markdown
Owner Author

jhaals commented Dec 5, 2025

fixes #3159

Signed-off-by: Johan Haals <johan.haals@gmail.com>
@jhaals jhaals merged commit b09ecc4 into master Dec 9, 2025
13 of 14 checks passed
@jhaals jhaals deleted the fix/3159-ui-improvements branch December 9, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant