Fix multiple UI issues for secret display#3209
Merged
Conversation
- Fix layout to properly position footer at bottom using flexbox - Fix QR code display logic to check decrypted data length instead of encrypted secret - Hide QR code button completely when secret is too long for QR - Add break-words CSS class to prevent text overflow in secret display - Increase QR code size from 180 to 250 for better readability - Remove trailing newline from index.css These changes improve the user experience when viewing decrypted secrets, particularly for long messages and QR code generation. Supersedes: fix/3159
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3209 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 8 8
Lines 808 808
=======================================
Hits 660 660
Misses 109 109
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
fixes #3159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the user experience when viewing decrypted secrets, particularly for long messages and QR code generation.
Includes all changes from #3159 contributed by @x1arch