Skip to content

clang-tidy warning in Fade.cpp #126

@jhasse

Description

@jhasse
/builds/bixense/jngl/src/jngl/Fade.cpp:50:14: warning: Moved-from object 'self' is moved [clang-analyzer-cplusplus.Move]
   50 |                                 setScene(std::move(self));
      |                                          ^~~~~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:30:6: note: Assuming the condition is false
   30 |         if (self.get() != this) {
      |             ^~~~~~~~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:30:2: note: Taking false branch
   30 |         if (self.get() != this) {
      |         ^
/builds/bixense/jngl/src/jngl/Fade.cpp:36:6: note: Assuming field 'quit' is false
   36 |         if (quit || fadeCount >= 2 * maxAlpha) { // Finished?
      |             ^~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:36:6: note: Left side of '||' is false
/builds/bixense/jngl/src/jngl/Fade.cpp:36:14: note: Assuming the condition is false
   36 |         if (quit || fadeCount >= 2 * maxAlpha) { // Finished?
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:36:2: note: Taking false branch
   36 |         if (quit || fadeCount >= 2 * maxAlpha) { // Finished?
      |         ^
/builds/bixense/jngl/src/jngl/Fade.cpp:40:6: note: Assuming 'wasHalfTime' is true
   40 |         if (!wasHalfTime && fadeCount >= maxAlpha) {
      |             ^~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:40:19: note: Left side of '&&' is false
   40 |         if (!wasHalfTime && fadeCount >= maxAlpha) {
      |                          ^
/builds/bixense/jngl/src/jngl/Fade.cpp:43:6: note: Assuming 'maxAlpha' is equal to field 'fadeCount'
   43 |         if (fadeCount == maxAlpha) {
      |             ^~~~~~~~~~~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:43:2: note: Taking true branch
   43 |         if (fadeCount == maxAlpha) {
      |         ^
/builds/bixense/jngl/src/jngl/Fade.cpp:45:3: note: '?' condition is true
   45 |                 assert(!getNextScene());
      |                 ^
/usr/include/assert.h:100:7: note: expanded from macro 'assert'
  100 |      (static_cast <bool> (expr)                                         \
      |       ^
/builds/bixense/jngl/src/jngl/Fade.cpp:46:3: note: Loop condition is true.  Entering loop body
   46 |                 while (dynamic_cast<WorkFactory*>(work.get())) {
      |                 ^
/builds/bixense/jngl/src/jngl/Fade.cpp:48:4: note: Taking true branch
   48 |                         if (auto correctScene = getNextScene()) {
      |                         ^
/builds/bixense/jngl/src/jngl/Fade.cpp:50:14: note: Object 'self' is moved
   50 |                                 setScene(std::move(self));
      |                                          ^~~~~~~~~~~~~~~
/builds/bixense/jngl/src/jngl/Fade.cpp:46:3: note: Loop condition is true.  Entering loop body
   46 |                 while (dynamic_cast<WorkFactory*>(work.get())) {
      |                 ^
/builds/bixense/jngl/src/jngl/Fade.cpp:48:4: note: Taking true branch
   48 |                         if (auto correctScene = getNextScene()) {
      |                         ^
/builds/bixense/jngl/src/jngl/Fade.cpp:50:14: note: Moved-from object 'self' is moved
   50 |                                 setScene(std::move(self));
      |                                          ^~~~~~~~~~~~~~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions