Skip to content

k8s: generate trustStore password instead of hardcoding (fixes #27051) #30651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

k8s: generate trustStore password instead of hardcoding (fixes #27051) #30651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generators/kubernetes/templates/deployment.yml.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ spec:
<%_ if (ingressTypeGke) { _%>
# Custom trustStore required when using Let's Encrypt staging
- name: JAVA_OPTS
value: "-Djavax.net.ssl.trustStore=/etc/pki/java/cacerts -Djavax.net.ssl.trustStorePassword=123456 -Xmx256m -Xms256m"
value: "-Djavax.net.ssl.trustStore=/etc/pki/java/cacerts -Djavax.net.ssl.trustStorePassword=<%= baseName %> -Xmx256m -Xms256m"
- name: SPRING_SECURITY_OAUTH2_CLIENT_PROVIDER_OIDC_ISSUER_URI
value: https://keycloak.<%= kubernetesNamespace %>.<%= ingressDomain %>/realms/jhipster
<%_ } else { _%>
Expand Down
6 changes: 3 additions & 3 deletions generators/kubernetes/templates/registry/jhipster-registry.yml.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ spec:
value: https://keycloak.<%= kubernetesNamespace %>.<%= ingressDomain %>/realms/jhipster
# Custom trustStore required when using Let's Encrypt staging
- name: JAVA_OPTS
value: "-Djavax.net.ssl.trustStore=/etc/pki/java/cacerts -Djavax.net.ssl.trustStorePassword=123456"
value: "-Djavax.net.ssl.trustStore=/etc/pki/java/cacerts -Djavax.net.ssl.trustStorePassword=<%= baseName %>"
<%_ } else { _%>
- name: SPRING_SECURITY_OAUTH2_CLIENT_PROVIDER_OIDC_ISSUER_URI
value: http://keycloak.<%= kubernetesNamespace %>.<%= ingressDomain %>/realms/jhipster
Expand All @@ -157,12 +157,12 @@ spec:
name: application-config
<%_ if (useKeycloak) { _%>
<%_ if (ingressTypeGke) { _%>
# When using Let's Encrypt staging certificates, for a successful start, add CAs to java truststore
# When using Let's Encrypt staging certificates, for a successful start, add CAs to java truststore
- name: java-truststore
secret:
secretName: letsencrypt-ca-secret
items:
- key: truststore.jks
path: cacerts
<%_ } _%>
<%_ } _%>
<%_ } _%>
Loading