Fix #19: Permit exiting early without more retries #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but will need a rebase after the cleanup I just did. Sorry about that, I pushed before noticing your PR! |
jimmycuadra
reviewed
May 25, 2019
rbtcollins
force-pushed
the
master
branch
2 times, most recently
from
100c162 to
544c3ce
Compare
jimmycuadra
requested changes
May 25, 2019
This is important for many cases where only some cases are safe to retry (e.g. non idempotent HTTP operations), or file system operations where unknown errors are undefined behaviour. Signed-off-by: Robert Collins <[email protected]>
jimmycuadra
approved these changes
May 25, 2019
|
Thanks much! This was a very nice feature addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for many cases where only some cases are safe to
retry (e.g. non idempotent HTTP operations), or file system operations
where unknown errors are undefined behaviour.
Signed-off-by: Robert Collins [email protected]