Add get/set LED state commands to player#89
Conversation
|
What is the use case for the getLED method? I usually don't implement polling actions for data that is evented, but rather keep that info as state. I don't remember if led state is evented though |
|
The system we are using this in has a blink command so that users may quickly determine what device they are talking to. Our blink implementation for the Sonos is to toggle the LED a couple times. In order to ensure we leave the LED in the same state it was pre-blink, we must first get its state. I don’t think the LED state is gettable via events. Looking at the upnp XML for my Sonos, LEDState has sendEvents set to no. |
|
The data can still be evented by another property, that is the case with AVTransport events, all of them are sent as part of LastChange, not individually. But DeviceProperties doesn't have a LastChange, so you maybe right. |
Adds the ability to get and set the LED state of a player.