perf: cache fully built data types in buildDataType()#178
Merged
jisotalo merged 1 commit intojisotalo:devfrom Dec 27, 2025
Merged
perf: cache fully built data types in buildDataType()#178jisotalo merged 1 commit intojisotalo:devfrom
buildDataType()#178jisotalo merged 1 commit intojisotalo:devfrom
Conversation
Owner
|
Thanks @crishoj, I'll try to check this through during holidays! |
jisotalo
added a commit
that referenced
this pull request
Dec 27, 2025
### Added - Added caching of built data types to improve performance - See [pull request #178](#178) ### Changed - Bug fix: Unhandled Promise rejections during automatic reconnecting - See [pull request #177](#177) - Fixed a Typescript warning at `socket.on("data", (data) => {...})` as the data chunk could be a string as well - Dependencies updated - Documentation updated
Merged
jisotalo
added a commit
that referenced
this pull request
Dec 27, 2025
## [2.2.0] - 27.12.2025 ### Added - Added caching of built data types to improve performance - See [pull request #178](#178) ### Changed - Bug fix: Unhandled Promise rejections during automatic reconnecting - See [pull request #177](#177) - Fixed a Typescript warning at `socket.on("data", (data) => {...})` as the data chunk could be a string as well - Dependencies updated - Documentation updated Thank you [Christian Rishøj](https://github.com/crishoj) for contribution! All tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildDataType()method is recursively rebuilding the full type hierarchy on every call, even though the underlyinggetDataTypeDeclaration()results are cached.This can cause significant CPU overhead with frequent ADS notifications.
This change adds a cache for the fully built data types (
builtDataTypes), similar to the existingplcDataTypescache:disableCachingsetting