Skip to content

feat: Add a colibri2 notification IQ.#124

Open
bgrozev wants to merge 1 commit intojitsi:masterfrom
bgrozev:conference-notification
Open

feat: Add a colibri2 notification IQ.#124
bgrozev wants to merge 1 commit intojitsi:masterfrom
bgrozev:conference-notification

Conversation

@bgrozev
Copy link
Member

@bgrozev bgrozev commented Jun 11, 2025

No description provided.

@savely-krasovsky
Copy link

savely-krasovsky commented Aug 21, 2025

I was about to open own PR with custom IQ to start/stop transcribation :) This seems to be more versatile. Any plans to merge it soon?

@savely-krasovsky
Copy link

savely-krasovsky commented Sep 4, 2025

@bgrozev but I am not sure how it is/was supposed to work. From what I see both Jibri and JVB doesn't emit their own IQs, they only listen and respond to them. This ConferenceNotificationIQ at least seems like the way to query Jicofo from JVB and wait an "ack" from it. Like "there is a problem with ICE, I am notifying you, please acknowledge". meetingId property supports this theory, because from my understanding this is the only way for Jicofo to know with which conference the problem occurred and update presence (to notify actual users). But I don't see any infrastructure for now to send stanzas from JVB to Jicofo. I am missing some Jicoco's mucclient update?

Comment on lines +34 to +36
init {
notifications.forEach { addExtension(it) }
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This init seems to be unnecessary causing duplicating of extensions (addNotification already calls addExtension method).

@savely-krasovsky
Copy link

By working more with JVB and Jicofo codebases this IQ seems more about pull-mode. Jicofo would poll JVBs for available Notification's and act accordingly (by sending updated presense for example). I am correct?

@Neustradamus
Copy link

@bgrozev, @savely-krasovsky: Any progress on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants