Open
Conversation
none of the existing helpers allowing getting an extension without a namespace
Member
Author
|
I think we'll call this a draft for now, as I haven't been able to try integrating this with actual code yet and may run into something there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This message is designed to allow us to send an arbitrary JSON payload over XMPP. This is perhaps counterintuitive, but the reasoning is that we plan to move away from XMPP in the future (to JSON over HTTP) so we're leaving the XMPP transport but defining the new messages now.
I made the
JsonPacketExtensionseparate because I think we'll get re-use out of it (Jibri already takes some JSON data and it would be nice to move over to this). I don't know that it's best done as a PacketExtension, though. I did run into some awkwardness around it not having a namespace (it didn't feel like one made sense for it) since extensions on anIQrequire lookup via a namespace (I had to add a helper function to work around this)--so suggestions are welcome.