fix(p2p): queue tracks that arrive before P2P mode is established#2959
Open
MikCam wants to merge 1 commit intojitsi:masterfrom
Open
fix(p2p): queue tracks that arrive before P2P mode is established#2959MikCam wants to merge 1 commit intojitsi:masterfrom
MikCam wants to merge 1 commit intojitsi:masterfrom
Conversation
Fixes race condition where WebRTC ontrack events fire before P2P mode is fully established. When tracks arrive before _setP2PStatus(true) completes, they are now queued and processed once the P2P connection is ready. Previously, tracks arriving during P2P establishment were ignored with "Trying to add remote P2P track, when not in P2P - IGNORED", causing tracks to never be added to the conference even after P2P was ready. Changes: - Add pendingP2PTracks queue to buffer tracks before P2P is ready - Add _p2pTracksProcessed flag to prevent duplicate processing - Modify _setP2PStatus to process queued tracks when P2P established - Modify onRemoteTrackAdded to queue instead of ignoring early tracks - Add conditional check before _addRemoteP2PTracks to avoid duplicates - Clear queue when exiting P2P mode
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes race condition where WebRTC ontrack events fire before P2P mode is fully established. When tracks arrive before _setP2PStatus(true) completes, they are now queued and processed once the P2P connection is ready.
Previously, tracks arriving during P2P establishment were ignored with "Trying to add remote P2P track, when not in P2P - IGNORED", causing tracks to never be added to the conference even after P2P was ready.
Changes:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots or GIF (In case of UI changes):
Types of changes
Checklist: