Skip to content

chore: improve type safety in getResolutionFromFailedConstraint using…#2982

Open
Darshini1213 wants to merge 1 commit intojitsi:masterfrom
Darshini1213:second-pr
Open

chore: improve type safety in getResolutionFromFailedConstraint using…#2982
Darshini1213 wants to merge 1 commit intojitsi:masterfrom
Darshini1213:second-pr

Conversation

@Darshini1213
Copy link

… nullish coalescing

test: improve JitsiTranscriptionStatus test with type safety and snapshot

Description

This PR improves the JitsiTranscriptionStatus Jest test with the following small but meaningful updates:

  1. Added TypeScript type annotation for destructured exports to improve type safety.
  2. Fixed minor formatting in the .withContext() message for cleaner console output.
  3. Added a snapshot test for JitsiTranscriptionStatus to detect accidental changes in the exported object in the future.

These changes maintain backward compatibility while enhancing test reliability and developer confidence.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots or GIF (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants