fix(chatroom): guard against undefined values to avoid crashes#2994
Open
Alok-work23 wants to merge 1 commit intojitsi:masterfrom
Open
fix(chatroom): guard against undefined values to avoid crashes#2994Alok-work23 wants to merge 1 commit intojitsi:masterfrom
Alok-work23 wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
Author
|
I have signed CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds null-safety guards in ChatRoom to prevent potential runtime errors when optional values are undefined.
Related Issue
N/A – This PR addresses a potential runtime issue identified during code review.
Motivation and Context
Both
participantPropertyListenerandnode.childrenare optional and may be undefined in certain scenarios.This PR ensures safer handling of these cases and improves overall robustness.
How Has This Been Tested?
N/A
Screenshots or GIF (In case of UI changes): N/A
Types of changes
Checklist: