generated from scaffold-eth/scaffold-eth
-
Notifications
You must be signed in to change notification settings - Fork 60
refactor: big ole proposal metadata, tests, rewards, and ranking refactor #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
siobh9
merged 11 commits into
feat/merkle-votes
from
refactor/move-sorting-and-ranking-to-GovCounting
Apr 22, 2023
Merged
refactor: big ole proposal metadata, tests, rewards, and ranking refactor #254
siobh9
merged 11 commits into
feat/merkle-votes
from
refactor/move-sorting-and-ranking-to-GovCounting
Apr 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
siobh9
commented
Apr 22, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum
andstruct
structureproposeWithoutProof()
RewardsModule
testsGovernorSorting
fromRewardsModule
to simplify the latter's code and provide more functionality to the formerGovernorMerkleVotes
out ofextensions
as it doesn't inheritGovernor
solhint
An issue I ran into though (fixed in this commit)
Unfortunately have to add a few
@ts-ignores
though because this block inJokeDaoV2Dev/packages/react-app-revamp/contracts/bytecodeAndAbi/Contest.3.1.merkleVotes.sol/Contest.json
:makes it so that when we try to filter the ABI in
JokeDaoV2Dev/packages/react-app-revamp/hooks/useContest/index.ts
, it gives an error saying that there are too many signatures in the array.Apparently this is being currently worked on by the Typescript team here and is a common problem when parsing ABIs. I found this for example, which helps, but it still ends up requiring a
@ts-ignore
because thenel
isn't typed.Just seems like it's a problem that requires a messy workaround, as we already do in our codebase when we read ABIs, which is unfortunate - but hopefully soon the TS team merges this PR and we can do things in the right, strictly typed way.