Skip to content

Make a hypothetical package:html #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/html.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export 'src/custom_element.dart';
export 'src/div_element.dart';
export 'src/element.dart';
export 'src/html_element.dart';
30 changes: 30 additions & 0 deletions lib/interop.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
class CustomElement extends HTMLElement {
constructor() {
super();
this.dartObject = null;
}

connectedCallback() {
this.dartObject.connected();
}

disconnectedCallback() {
this.dartObject.disconnected();
}

attributeChangedCallback(attr, oldVal, newVal) {
this.dartObject.attributeChanged(attr, oldVal, newVal);
}
}
window.CustomElement = CustomElement;

function defineElement(name, construct, observed) {
customElements.define(name, class extends CustomElement {
constructor() {
super();
construct(this);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First problem this hits in dart2js is that its not a function at this point. If you change it locally to construct.call$1 it gets further.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which call isn't a function yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the inspector its listed as a Closure so its not a JS function.
closure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I added the construct.call$1 in there.

}

static get observedAttributes() { return observed; }
});
};
22 changes: 22 additions & 0 deletions lib/src/custom_element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import 'html_element.dart';
import 'js.dart' as js;

typedef CustomElementConstructor = CustomElement Function(
js.CustomElement element);

class CustomElement extends HtmlElement {
CustomElement(js.HtmlElement element) : super(element);

void connected() {}
void disconnected() {}
void attributeChanged(String attribute, String oldValue, String newValue) {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods will get removed by dart2js as they are really only referenced by the JS. The other problem is they get mangled as well so the JS code can't call them directly.


// Register
static void register(
String tag,
CustomElementConstructor constructor, [
List<String> observed = const <String>[],
]) {
js.defineElement(tag, constructor, observed);
}
}
7 changes: 7 additions & 0 deletions lib/src/div_element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import 'js.dart' as js;

import 'html_element.dart';

class DivElement extends HtmlElement {
DivElement(js.HtmlElement element) : super(element);
}
27 changes: 27 additions & 0 deletions lib/src/element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import 'package:meta/meta.dart';

import 'div_element.dart';
import 'js.dart' as js;

abstract class Element<T extends js.Element> {
///
@protected
Element(this.jsObject) {
jsObject.dartObject = this;
}

@protected
final T jsObject;
}

DivElement div() => tagName('div') as DivElement;

Element tagName(String tag) {
final jsElement = js.document.createElement(tag);

if (tag == 'div') {
return DivElement(jsElement);
}

return null;
}
26 changes: 26 additions & 0 deletions lib/src/html_element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import 'element.dart';
import 'js.dart' as js;

abstract class HtmlElement<T extends js.HtmlElement> extends Element<T> {
HtmlElement(T jsObject) : super(jsObject);

void click() {
print('Im clicking');
jsObject.click();
}

void focus() {
print('Im focusing');
jsObject.focus();
}

void blur() {
print('Im bluring');
jsObject.blur();
}

String get text => jsObject.innerText;
set text(String value) {
jsObject.innerText = value;
}
}
5 changes: 5 additions & 0 deletions lib/src/js.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export 'js/custom_element.dart';
export 'js/dart_wrapper.dart';
export 'js/document.dart';
export 'js/element.dart';
export 'js/html_element.dart';
13 changes: 13 additions & 0 deletions lib/src/js/custom_element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@JS()
library html_proto.src.js.custom_element;

import 'package:js/js.dart';

import 'html_element.dart';

@JS('CustomElement')
abstract class CustomElement implements HtmlElement {}

@JS('defineElement')
external void defineElement(
String name, Function constructor, List<String> observed);
5 changes: 5 additions & 0 deletions lib/src/js/dart_wrapper.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
/// A JSObject that contains a Dart object.
abstract class DartWrapper {
/// The object from Dart.
dynamic dartObject;
}
14 changes: 14 additions & 0 deletions lib/src/js/document.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
@JS()
library html_proto.src.js.document;

import 'package:js/js.dart';

import 'html_element.dart';

@JS('Document')
abstract class Document {
HtmlElement createElement(String tag);
}

@JS('document')
external Document get document;
9 changes: 9 additions & 0 deletions lib/src/js/element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
@JS()
library html_proto.src.js.element;

import 'package:js/js.dart';

import 'dart_wrapper.dart';

@JS('Element')
abstract class Element implements DartWrapper {}
16 changes: 16 additions & 0 deletions lib/src/js/html_element.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
@JS()
library html_proto.src.js.html_element;

import 'package:js/js.dart';

import 'element.dart';

@JS('HTMLElement')
abstract class HtmlElement implements Element {
void click();
void focus();
void blur();

String get innerText;
set innerText(String value);
}
5 changes: 3 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: customElementDemo
description: An absolute bare-bones web app.
name: html_proto
description: Alternate dart:html prototype.
# version: 1.0.0
#homepage: https://www.example.com
#author: Jenny Messerly <[email protected]>
Expand All @@ -9,6 +9,7 @@ environment:

dependencies:
js: ^0.6.0
meta: ^1.1.6

dev_dependencies:
build_runner: ^0.10.0
Expand Down
5 changes: 3 additions & 2 deletions web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="scaffolded-by" content="https://github.com/google/stagehand">
<title>customElementDemo</title>
<title>HTML Prototype Demo</title>
<link rel="stylesheet" href="styles.css">
<link rel="icon" href="favicon.ico">
<script defer src="interop.js"></script>
<script defer src="packages/html_proto/interop.js"></script>
<script defer src="main.dart.js"></script>
</head>
<body>
<greeting-element></greeting-element>
</body>
</html>
24 changes: 0 additions & 24 deletions web/interop.js

This file was deleted.

58 changes: 15 additions & 43 deletions web/main.dart
Original file line number Diff line number Diff line change
@@ -1,55 +1,27 @@
@JS()
library main;
import 'package:html_proto/html.dart';
import 'package:html_proto/src/js.dart' as js;

import 'dart:html';
import 'package:js/js.dart';
class GreetingElement extends CustomElement {
GreetingElement(js.CustomElement element) : super(element);

@JS('CustomElement')
abstract class JSCustomElement<T extends CustomElement> implements HtmlElement {
T asDart;
}

typedef CustomElementConstructor = CustomElement Function(JSCustomElement e);

@JS('defineElement')
external void defineElement(String name, CustomElementConstructor constructor);

class CustomElement {
final JSCustomElement element;

CustomElement(this.element) {
element.asDart = this;
void connected() {
print('Hello I\'m connected now');
text = 'Hello from Dart';
}

void connected() {}
void disconnected() {}
}

class HelloElement extends CustomElement{
HelloElement(JSCustomElement element) : super(element);

void sayHello() {
element.text = 'Hello from Dart!';
element.style.color = '#0175C2';
void disconnected() {
print('Goodbye I\'m being disconnected now');
}
}

class GoodbyeElement extends CustomElement {
GoodbyeElement(JSCustomElement element) : super(element);
void attributeChanged(String attribute, String oldValue, String newValue) {
text = 'Hello from Dart ${newValue}';

void sayGoodybe() {
element.text = 'Goodbye from Dart!';
element.style.color = '#0175C2';
print('Attribute: $attribute');
print('Old value: $oldValue');
print('New value: $newValue');
}
}

void main() {
defineElement('dart-goodbye', allowInterop((e) => GoodbyeElement(e)));
defineElement('dart-hello', allowInterop((e) => HelloElement(e)));

var hello = document.body.append(Element.tag('dart-hello')) as JSCustomElement<HelloElement>;
hello.asDart.sayHello();

var goodbye = document.body.append(Element.tag('dart-goodbye')) as JSCustomElement<GoodbyeElement>;
goodbye.asDart.sayGoodybe();
CustomElement.register('greeting-element', (e) => GreetingElement(e), ['name']);
}