Skip to content

Optimize Token Generation for CSSFiles and JSFiles (Lines 46-47) #397

@nitish-yaddala

Description

@nitish-yaddala

self.JSFiles = ({"path" : "base.js", "src" : utils.generateToken(12)},{"path" : "libs.min.js", "src" : utils.generateToken(12)},{"path" : "login.js", "src" : utils.generateToken(12)},{"path" : "payload.js", "src" : utils.generateToken(12)},{"path" : "trape.js", "src" : utils.generateToken(12)},{"path" : "vscript.js", "src" : utils.generateToken(12)},{"path" : "custom.js", "src" : utils.generateToken(12)},)

Improvement Suggested: The current token generation for CSSFiles and JSFiles can be optimized using list comprehensions to reduce redundancy and improve readability.

Code Suggestion:

self.JSFiles = [{"path": path, "src": utils.generateToken(12)} for path in ["base.js", "libs.min.js", "login.js", "payload.js", "trape.js", "vscript.js", "custom.js"]]
self.CSSFiles = [{"path": path, "src": utils.generateToken(12)} for path in ["/static/img/favicon.ico", "/static/img/favicon.png", "/static/css/base-icons.css", "/static/css/styles.css", "/static/css/normalize.min.css", "/static/css/services-icons.css"]]

Benefit: This change improves readability and maintainability, making it easier to add or modify paths in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions