-
Notifications
You must be signed in to change notification settings - Fork 11
7 option to select model #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Model opt is passed to the -m flag of the codex command - Single border is no longer a duplicate of rounded
- BREAKING CHANGE: Buffer toggle was originally assigned to <Esc>, now assinged to <q>. This change is to not conflict with Codex CLI's newer methodology of handling agent interupts, via <Esc><Esc>. - Buffer now backgrounds smoothly, without any delay upon q press
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for selecting a specific AI model via the -m flag, refactors buffer creation/reuse, and updates tests, documentation, and CI workflows to align with these changes.
- Introduce
modeloption in config and include-m <model>in spawned command - Refactor buffer setup into
create_clean_bufwith reuse logic - Update tests for table-based
cmdand add new model-passing spec - Refresh README and adjust Makefile/CI configs
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/specs/codex_spec.lua | Updated cmd usage, added model test, remove debug code |
| makefile | Point test runner at tests/specs/ directory |
| lua/codex/init.lua | Add model config, buffer creation helper, inject flag |
| README.md | Document new model option and keybinding changes |
| .github/workflows/ci.yml | Remove extra branch, add semantic-release job |
Comments suppressed due to low confidence (2)
tests/specs/codex_spec.lua:50
- This print statement and the manual buffer-modified reset appear to be leftover debug code—consider removing them to keep tests clean and avoid noisy output.
print('🔍 buffer modified before toggle:', vim.api.nvim_buf_get_option(buf, 'modified'))
tests/specs/codex_spec.lua:62
- The syntax here places
'1000'outside thecmdtable; usecmd = { 'sleep', '1000' }to pass both elements correctly as a list.
require('codex').setup { cmd = 'sleep', '1000' }
No description provided.