Skip to content

Conversation

@johnseth97
Copy link
Owner

No description provided.

- Model opt is passed to the -m flag of the codex command
- Single border is no longer a duplicate of rounded
- BREAKING CHANGE: Buffer toggle was originally assigned to <Esc>, now
assinged to <q>. This change is to not conflict with Codex CLI's newer
methodology of handling agent interupts, via <Esc><Esc>.

- Buffer now backgrounds smoothly, without any delay upon q press
@johnseth97 johnseth97 requested a review from Copilot June 19, 2025 04:15
@johnseth97 johnseth97 self-assigned this Jun 19, 2025
@johnseth97 johnseth97 added the enhancement New feature or request label Jun 19, 2025
@johnseth97 johnseth97 linked an issue Jun 19, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for selecting a specific AI model via the -m flag, refactors buffer creation/reuse, and updates tests, documentation, and CI workflows to align with these changes.

  • Introduce model option in config and include -m <model> in spawned command
  • Refactor buffer setup into create_clean_buf with reuse logic
  • Update tests for table-based cmd and add new model-passing spec
  • Refresh README and adjust Makefile/CI configs

Reviewed Changes

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/specs/codex_spec.lua Updated cmd usage, added model test, remove debug code
makefile Point test runner at tests/specs/ directory
lua/codex/init.lua Add model config, buffer creation helper, inject flag
README.md Document new model option and keybinding changes
.github/workflows/ci.yml Remove extra branch, add semantic-release job
Comments suppressed due to low confidence (2)

tests/specs/codex_spec.lua:50

  • This print statement and the manual buffer-modified reset appear to be leftover debug code—consider removing them to keep tests clean and avoid noisy output.
    print('🔍 buffer modified before toggle:', vim.api.nvim_buf_get_option(buf, 'modified'))

tests/specs/codex_spec.lua:62

  • The syntax here places '1000' outside the cmd table; use cmd = { 'sleep', '1000' } to pass both elements correctly as a list.
    require('codex').setup { cmd = 'sleep', '1000' }

@johnseth97 johnseth97 merged commit 26f1754 into main Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to select model

2 participants