Added phone number patterns for de_CH and it_CH #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I did not touch the module where typing tests fail. Should probably be fixed separately? |
Collaborator
|
The typing issue is now fixed on master |
fcurella
force-pushed
the
master
branch
9 times, most recently
from
aa137ce to
c330978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
In addition to
fr_CH, this adds phone number patterns forde_CHandit_CH(they are identical for all three locales). Also, patterns were updated to match valid CH phone numbers as closely as possible according to https://de.wikipedia.org/wiki/Telefonnummer_(Schweiz)#Schreibweisen.What was wrong
Patterns were only present for
fr_CH, so faker threw an exception when the locale was set to eitherde_CHorit_CHHow this fixes it
New patterns add support for the missing locales
Fixes #2148
Checklist
make lint