Fix unnatural Korean company names in ko_KR locale #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-4bb1t
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This improves the realism of company names generated for the ko_KR locale.
Replaces last_name-based company name formats with more natural Korean naming patterns
Adds company_name_words (e.g., "미래", "한빛", "코리아") and company_name_suffixes (e.g., "테크", "소프트") for constructing company names
What was wrong
The original Korean company names were generated using combinations of Korean last names (e.g.,
{{last_name}}{{last_name}}), which resulted in highly unnatural outputs like:(주) 김박김Such combinations do not reflect how real Korean company names are structured.
How this fixes it
By introducing a curated list of real-sounding company name roots and suffixes, and updating the formats accordingly, the generated company names now resemble realistic Korean business names.
Examples after this change:
(주) 미래소프트,주식회사 브레인랩스,유한회사 코리아시스템Fixes #2229
Checklist
make lint