fix(constructor): better check for property exists when building constructor args #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
reviewed
Mar 5, 2025
| public function testConstructorAndRelationMissing(): void | ||
| { | ||
| $user = ['name' => 'foo']; | ||
| $this->expectException(MissingConstructorArgumentsException::class); |
Member
There was a problem hiding this comment.
i added this, from the input this is the expected use case
joelwurtz
reviewed
Mar 5, 2025
|
|
||
| public function testConstructorAndRelationMissing2(): void | ||
| { | ||
| $user = ['name' => 'foo', 'int' => ['foo' => 1]]; |
Member
There was a problem hiding this comment.
I changed the input array, passing an Object will not work as we expecte pure base type when mapping from array, if there is something else then a transformer should be provided
joelwurtz
reviewed
Mar 5, 2025
| /** @var Fixtures\UserConstructorDTOWithRelation $userDto */ | ||
| $userDto = $this->autoMapper->map($user, Fixtures\UserConstructorDTOWithRelation::class, [ | ||
| MapperContext::CONSTRUCTOR_ARGUMENTS => [ | ||
| Fixtures\UserConstructorDTOWithRelation::class => ['int' => new Fixtures\IntDTO(1)], |
Member
There was a problem hiding this comment.
class was wrong, i put the correct one and it works as expected
Member
Author
|
Thanks 👍🏼 |
lyrixx
changed the title
Member
Author
|
thanks 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.