feat(remover): remove existing values when adder and remover #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
commented
Apr 5, 2025
| self::assertSame('cat', $petOwner->getPets()[1]->type); | ||
| self::assertSame('Coco', $petOwner->getPets()[2]->name); | ||
| self::assertSame('dog', $petOwner->getPets()[2]->type); | ||
| self::assertCount(2, $petOwner->getPets()); |
Member
Author
There was a problem hiding this comment.
poke @Korbeil is this acceptable ? should we consider this PR as a BC break given that i had to change that or do we consider this a bug ?
Member
Author
There was a problem hiding this comment.
I will merge this, we can always revert before release, i need this for another PR
Member
There was a problem hiding this comment.
I do think it's fine since it's kinda a bug that we are adding without removing nowadays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #227