-
Notifications
You must be signed in to change notification settings - Fork 59
Options for filaments #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ss1gohan13
wants to merge
116
commits into
jontek2:main
Choose a base branch
from
ss1gohan13:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated for the SV08
Swapped some verbiage from Voron to SV08
Formatting and spelling
Note added about CHAMBER thermistor and being omited.
Formatting, spelling, HTML correction, and linked to new thermistor doc
Formatting and HTML corrections
Updated slicer gcode for no thermistors, updated 2nd start print gcode for no thermsitor, updated verbiage
Updated start print macro with formatting changes due to failure to call bed temp. Added conditional QGL to both start print macros.
Removed: ` SET_FILAMENT_SENSOR SENSOR=filament_sensor ENABLE=1` from start print macro. Was experimental with another filament sensor experiment
added referral link: https://github.com/ss1gohan13/SV08-Replacement-Macros/blob/main/macros/macro.cfg to line 228
Removed first SMART_PARK from both start print macros
Formatting and minor corrections
Added custom predefined material in the start print - when sending material data, the printer will recognize and use
Forgot to update slicer start gcodes and the "without thermistor" start print macro
removed note about removing CHAMBER - deprecated info
removed sv08 edition - not needed after expanding macro and adding in ztilt and qgl with comments. Now has closer resemblance to original
changed note about the thermistor check and that there is an alt macro for a "no chamber thermistor" printer.
removed specific calls to the SV08. Made it more generic
Missed some mentions of the SV08 to remove and removed more
forgot to add [MATERIAL] to the machine start gcode
modified feedback area at the bottom.
provided a link to KAMP within the wording of KAMP
Removed ABS/ASA from filament as they are normally printed with bed temp over 90C, so are not needed to be called in the filament options.
Added conditional G28 Z if Z tilt OR QGL was completed
Chamber thermistor and nevermore are *technically* optional. Updated verbiage to state Required (and/or optional) as the nevermore is not technically required and a substitute macro is in place if no thermistor is added to the config.
spelling
corrected issue with chamber thermistor macro
corrected chamber macro again
old conditional z homing was found in stiall script - updated - still known bug with double tapping Z home
Bug with start print macro - fixed again (unknown elif error)
Fixed elif bug
Modified start print macro to no longer include eddy tap or eddy scanning. These should be enabled by the end user if they are planning to use eddy. Stock klipper configs do not come with eddy ng or eddy configs by default. Similar to Klipper LED effects.
Updated install script macro to reflect updated changes to readme
Updated macro for conditional checks. Will check for enhanced gantry leveling macro, if that doesn't exist, fall back to stock klipper macros for ztilt and qgl.
Updated install script to reflect the new macro changes in previous notes. Conditional check for new gantry leveling macro, if not there, fall back to conditional ztilt and qgl stock macros.
verbiage update to correct a misunderstanding whether to "add to existing machine gcode" or "overwrite existing gcode".
more verbiage changes
Specific announcement for SV08 users
Spelling and gramical error corrections
chamber thermistor and nevermore verbiage updates. No longer need to comment/uncomment anything. Only need to ensure that devices are called correctly as all checks are now conditional to use/activate.
Updated macro to remove unnecessary target chamber check
removed unnecessary macro check for chamber temp (that was also in readme) and invalid.
removed extra endif in start print macro
Correct endif and reimplemented Gantry Leveling macro
… have the chamber sensor
Make clear we are going to wait 15min because of the missing chamber sensor
Added change to to heat soak time with no chamber thermistor to match recent PR
Commented out eddy ng tap for non eddy ng users in the install script.
commented out the rapid scan in the install script to match the github read me
Added a warning about the importance of the End Print Macro.
Updated verbiage on nevermore install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've been using your start print macro for a long time and have been loving it! I've since now started getting into different filament types and such. With that, I wanted a little bit more verbose options when it came to printing some different filaments. So I added a [MATERIAL] section in the machine start gcode and added variable/conditional options for the various filament types that are being called. I left the list short and generic, but if for example, PLA+ is called instead of PLA, it will still state it is a valid filament type. I can take some time to add in some additional filament types as well, but for now left it generic.
Let me know if you'd like to merge any of the data!