Skip to content

[4.x] add createQuery to DatabaseInterface #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 4.x-dev
Choose a base branch
from

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Mar 15, 2025

Pull Request for Issue #

Summary of Changes

adds createQuery to DatabaseInterface

Testing Instructions

  • only interface updated
  • check every class which implements DatabaseInterface must contain createQuery

Documentation Changes Required

Every class which implements DatabaseInterface must contain createQuery

heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Mar 15, 2025
heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Mar 15, 2025
@Hackwar
Copy link
Contributor

Hackwar commented Mar 30, 2025

I'd really like to merge this PR, however I would need some documentation for this similar to what is here: https://github.com/joomla-framework/database/blob/3.x-dev/docs/v1-to-v2-update.md
Can you please add a file with a few lines to describe this? Thank you!

@Hackwar
Copy link
Contributor

Hackwar commented Mar 30, 2025

Can you also check if you got everything from #311 covered in your PR as well? Then I would close the other PR.

@heelc29
Copy link
Contributor Author

heelc29 commented May 19, 2025

Can you also check if you got everything from #311 covered in your PR as well? Then I would close the other PR.

Yes, it contains all changes from #311 without deprecation message using backtrace #311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants