Skip to content

[6.0] Remove deprecated none namespaced helpers #45339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 17, 2025

Summary of Changes

Remove deprecated none namespaced helper classes. They are obsolete since 4.0 and it is really recommended to use the namespaced ones instead.

Testing Instructions

Install test sample data and browse around the front end and back end.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Add removed helper files Manual#440

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo requested a review from Hackwar as a code owner April 17, 2025 06:32
@HLeithner HLeithner added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Apr 17, 2025
@exlemor
Copy link

exlemor commented Apr 19, 2025

Hi @laoneo, did I mis-understand this test?

When I tried to use the Patch Tester with this PR (and perhaps that is where my mistake was), I got an error message:

The file marked for modification does not exist: ruleset.xml

(if I am supposed to download one of the pre-built packages, I will)

@laoneo
Copy link
Member Author

laoneo commented Apr 19, 2025

The ruleset file is not part of the installation package, that's probably the reason for the error.

@exlemor
Copy link

exlemor commented Apr 19, 2025

The ruleset file is not part of the installation package, that's probably the reason for the error.

ok so sorry, since it doesn't let me install the Patch, does that mean I need to use the prebuilt package to test this PR or do you need to update the PR?

@brianteeman
Copy link
Contributor

You wont be able to test this with anything other than a git checkout as ruleset is not part of a built/distributed package

@exlemor
Copy link

exlemor commented Apr 19, 2025

You wont be able to test this with anything other than a git checkout as ruleset is not part of a built/distributed package

Thanks @brianteeman for the explanation.

@laoneo laoneo closed this May 26, 2025
@laoneo laoneo deleted the helpers branch May 26, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants