Skip to content

[6.0] Remove CMS DB aware trait #45340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 17, 2025

Summary of Changes

Removes the deprecated CMS DatabaseAwareTrait class, as the one from the framework should be used instead.

Testing Instructions

Install test sample data and browse around the front end and back end.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Remove CMS DB aware trait Manual#441

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Apr 17, 2025
@laoneo
Copy link
Member Author

laoneo commented May 5, 2025

@wilsonge while you on it, might want to have a look here as well.

@laoneo laoneo closed this May 26, 2025
@laoneo laoneo deleted the mvcdbtrait branch May 26, 2025 07:24
@rdeutz rdeutz restored the mvcdbtrait branch May 28, 2025 16:07
@rdeutz rdeutz reopened this May 28, 2025
@wilsonge wilsonge enabled auto-merge (squash) May 30, 2025 13:35
@ceford
Copy link
Contributor

ceford commented May 30, 2025

I have tested this item ✅ successfully on 4b27ea0

Applied the patch and poked around - no issues. But I am not sure I know enough to test this patch!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45340.

@peterpeter
Copy link
Contributor

I wont to test this patch. Patchtester 'says':
"The file marked for modification does not exist: ruleset.xml"
https://prnt.sc/f6pssNowfkNy


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45340.

@brianteeman
Copy link
Contributor

Unfortunately, some pull requests cannot be tested with the patch tester. This is one of them. If you still want to test this, you can use one of the pre-built packages for this pull request

1 similar comment
@brianteeman
Copy link
Contributor

Unfortunately, some pull requests cannot be tested with the patch tester. This is one of them. If you still want to test this, you can use one of the pre-built packages for this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants