Skip to content

Fix handlebars templates reporting missing objects #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Fix handlebars templates reporting missing objects #1213

merged 1 commit into from
May 30, 2023

Conversation

christian-schilling
Copy link
Member

No description provided.

LMG
LMG reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@LMG LMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what about making it a helper since all of the code is super similar? Also you need to run cargo fmt again (or maybe your version is wrong)

LMG
LMG reviewed May 29, 2023
View reviewed changes
@christian-schilling
Fix handlebars templates reporting missing objects
c40f808 
The handlebars code was not yet converted to using alternate object stores.
We did not notice this issue at first,  because templateing is only tested with the
cli and the cli does not use alternates.

Change: fix-handlebars
@LMG LMG merged commit 8a764ad into master May 30, 2023
@LMG LMG deleted the @changes/master/[email protected]/fix-handlebars branch May 30, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMG LMG LMG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-schilling @LMG