feat: handle double quotes lodash imports #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found this code from https://github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js#L18. Thank you @mikeduminy !
josteph
changed the title
Owner
|
Thanks @omeraplak 🙏 |
github-actions bot
pushed a commit
to digitalmaas/esbuild-plugin-lodash
that referenced
this pull request
Jun 5, 2024
## 1.0.0 (2024-06-05) ### Features * add initial plugin ([9ed8499](9ed8499)) * Add outLodashPackage feature to allow for lodash-es, fix .cjs and .mjs files. ([josteph#2](https://github.com/digitalmaas/esbuild-plugin-lodash/issues/2)) ([f604fee](f604fee)) * fork `eslint-plugin-lodash`, add extension support ([7cf24d6](7cf24d6)) * handle double quotes lodash imports ([josteph#4](https://github.com/digitalmaas/esbuild-plugin-lodash/issues/4)) ([ee59f86](ee59f86)), closes [/github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js#L18](https://github.com/digitalmaas//github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js/issues/L18) ### Bug Fixes * import lodash/last bug ([#1](#1)) ([e91dff2](e91dff2)) * loader & function type ([e710105](e710105)) * remove namespace option, use esbuild default namespace ([489d8b3](489d8b3)) * rename plugins ([da4f0e4](da4f0e4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this solution from https://github.com/mikeduminy/esbuild-plugin-ramda/blob/main/index.js#L18. Thank you @mikeduminy !