This repository was archived by the owner on May 26, 2020. It is now read-only.
Fix redundant jwt.decode()
calls when JWT_GET_USER_SECRET_KEY
is None
#416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, it does not make any sense to perform TWO
jwt.decode()
, just trying to getuser_id
even when it's not used. The logic is now updated so that it will be short-circuited.Interestingly, I found a previous commit from the original contributor:
13ca172
It used
jwt_get_secret_key(user_id=None)
before. However, it did not avoid making twojwt.decode()
.This PR fixed such issue.
jwt.decode()
is somewhat expensive call and we should not call it unnecessarily.