Comment when /lgtm or /approve are unauthorized #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When someone tries to use /lgtm or /approve, but they are not authorized to perform that action, log the error but also comment back on the pull request so that they know that their slash command didn't work. Signed-off-by: Carolyn Van Slyck <[email protected]>
When I first wrote these tests, I found it easier to assert that the handlers threw an error, even though the rest of the tests were doing the asserts through the mocks. Now that the failure case works better with that pattern, because we are calling the comment api when we throw an error, it's easier to use the same type of tests, calling the issue comment handler instead of lgtm directly. So I've updated the tests to work like the rest. Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
jpmcb
reviewed
May 24, 2022
Owner
jpmcb
left a comment
jpmcb
left a comment
There was a problem hiding this comment.
Wow - this is incredible and actually something I've wanted to do for a long time.
I'm away and off work for the next few weeks but just wanted to drop a note that this is so cool, get eyes on it, and I'm planning to take a deep dive on this once I'm back 👏🏼
Contributor
Author
|
Enjoy your break! 🏖️ |
jpmcb
approved these changes
Jun 10, 2022
Owner
jpmcb
left a comment
jpmcb
left a comment
There was a problem hiding this comment.
Awesome! Looks great!! I think main is pretty close to being able to cut a release; we can get that out soon.
Thank you so much for this contribution!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone tries to use /lgtm or /approve, but they are not authorized to perform that action, log the error but also comment back on the pull request so that they know that their slash command didn't work.
Screenshot below shows what the comments look like when you aren't in the OWNERS file, or if there isn't an OWNERS file, for /lgtm and /approve.