Skip to content

Fixing invalid ref with invalid scrollHeight #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cutterbl merged 5 commits into from
Oct 30, 2023
Merged

Fixing invalid ref with invalid scrollHeight #2459

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fac76b
feat(time-grid): fixed invalid ref content
eduhdev12 Oct 26, 2023
ef15129
feat(lib): builded lib
eduhdev12 Oct 26, 2023
13dc42b
Revert "feat(lib): builded lib"
eduhdev12 Oct 26, 2023
416267d
chore: better checking
eduhdev12 Oct 26, 2023
94ed226
feat(time-grid): changed condition
eduhdev12 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/TimeGrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,11 @@ export default class TimeGrid extends Component {
calculateScroll(props = this.props) {
const { min, max, scrollToTime, localizer } = props

const diffMillis = localizer.diff(localizer.merge(scrollToTime, min), scrollToTime, 'milliseconds')
const diffMillis = localizer.diff(
localizer.merge(scrollToTime, min),
scrollToTime,
'milliseconds'
)
const totalMillis = localizer.diff(min, max, 'milliseconds')

this._scrollRatio = diffMillis / totalMillis
Expand All @@ -392,6 +396,8 @@ export default class TimeGrid extends Component {
if (this._updatingOverflow) return

const content = this.contentRef.current

if (!content || !content?.scrollHeight) return
let isOverflowing = content.scrollHeight > content.clientHeight

if (this.state.isOverflowing !== isOverflowing) {
Expand Down