Day layout bugfix #916
Closed
Day layout bugfix #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated onSameRow to account for event overlaps in either direction (a overlapping b OR b overlapping a)
Continuation of prev commit
Contributor
Author
|
Closing this PR in favor of #910. That resolves the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've found a fix for #899. This allows for more events to be classified as 'leaves' instead of 'rows' in the day layout algorithm, which I think was the intended approach. @tobiasandersen sorry I keep bugging you about this. Hoping this is the fix.
Before:
After: