Skip to content

air.js.org #9498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2025
Merged

air.js.org #9498

merged 3 commits into from
Jan 16, 2025

Conversation

SisyphusZheng
Copy link
Contributor

The site content is a documentation site for my JavaScript framework, AirJS, showcasing its features, API references, and usage examples.

@MattIPv4 MattIPv4 changed the title Update cnames_active.js air.js.org Jan 16, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your js.org domain request, your site must have reasonable content.
Based on https://openwebstudio.github.io/AirJS/ your site currently does not contain what we would consider to be reasonable content to grant a request.

image

Please see the wiki article: https://github.com/js-org/js.org/wiki/No-Content 📖

@MattIPv4
Copy link
Member

Looking at https://github.com/openwebstudio/AirJS/blob/gh-pages/build/index.html, I suspect you want to be outputting what is currently in build/ into the root of gh-pages, or update your repository configuration to be serving from the build/ directory instead of the root.

@MattIPv4 MattIPv4 added the no content This PR has a target that contains no valid content for a request label Jan 16, 2025
@SisyphusZheng
Copy link
Contributor Author

Hi JS.ORG maintainers,

I have updated my site to include reasonable content as per your guidelines.
The updated site is live at: https://openwebstudio.github.io/Air-Docs/.

screenshot-1737010970235

Key improvements:

  • Added a detailed description of AirComponents and AirJS in the future.
  • Included interactive examples showcasing core functionality.
  • Enhanced page design for better user experience.

Please kindly review the updated content and reconsider my subdomain request.

Thank you for your time!

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed no content This PR has a target that contains no valid content for a request labels Jan 16, 2025
@indus
Copy link
Member

indus commented Jan 16, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line air.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@indus
Copy link
Member

indus commented Jan 16, 2025

Because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@SisyphusZheng
Copy link
Contributor Author

Hi JS.ORG maintainers,
I have resolved all the issues mentioned earlier:
Added a CNAME file with air.js.org to the deployment directory.
Fixed the deployment path, and the site is now correctly serving the intended content.
The updated site is live at https://air.js.org.
Please review the changes and proceed with merging the PR.
screenshot-1737038453575

Thank you for your support!

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jan 16, 2025
@indus
Copy link
Member

indus commented Jan 16, 2025

Welcome https://air.js.org

@indus indus merged commit 01bd605 into js-org:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants