Skip to content

grab.js.org #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

grab.js.org #9810

merged 2 commits into from
May 28, 2025

Conversation

vtempest
Copy link
Contributor

@vtempest vtempest commented May 26, 2025

The site content is .grab is like fetch meets Tanstack query

grab is like  fetch meets Tanstack query
@MattIPv4 MattIPv4 changed the title grab-api js - its like fetch meets tanstack grab.js.org May 26, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ The site you have linked to for your js.org domain request returns a 404: https://vtempest.github.io/grab-api.js
Please fix this before we can process your js.org domain request. 🛠

@MattIPv4 MattIPv4 added the 404 The page requested returns a 404 response label May 26, 2025
@indus
Copy link
Member

indus commented May 27, 2025

@vtempest I think you wanted to add "grab": "vtempest.github.io/grab-api", not "grab": "vtempest.github.io/grab-api.js",

You should also fix the checkboxes in the PR text (not [ x] nor [ x] but [x]) and add the link to The site content can be seen at. Otherwise our CI has complains

@vtempest
Copy link
Contributor Author

vtempest commented May 27, 2025

I have changed the url in the new pr
: vtempest.github.io/grab-api

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed 404 The page requested returns a 404 response labels May 27, 2025
@indus
Copy link
Member

indus commented May 27, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label May 28, 2025
@indus
Copy link
Member

indus commented May 28, 2025

Welcome https://grab.js.org

@indus indus merged commit 4f692a6 into js-org:master May 28, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants