Repository navigation
Bump Node.js floor and dependencies - #4170
Conversation
7a22d7e to
2097b36
Compare
|
Seems like the failures are in |
2097b36 to
00ffcdf
Compare
|
Wouldn't it be better not to change the minimum support for v22 and v24? |
It would be, but some of our dependencies / dev deps have higher minimums... Also some of them exclude v25, which I am not sure what to do about. Edit: specifically, it's I guess I am OK with it because I generally prefer people be running the latest versions of things anyway, and only support older things because I want to respect the semver contract. |
Update the minimum supported Node.js version to exclude Node 20 and refresh direct dependencies that now rely on newer runtimes. Remove compatibility code that is no longer needed with the new Node and undici floors, including old undici handler adaptation, Node 20 ArrayBuffer.transfer fallbacks, direct minimatch usage for WPT expectations, and Node 20-only WPT skips. Co-Authored-By: codex <codex@openai.com>
00ffcdf to
2ea432e
Compare
|
I also agree with encouraging the use of the latest Node.js, but taking in this npm-run-all2 update feels too impactful considering where jsdom stands. Could we just stick with the current npm-run-all2 for now and maybe consider swapping to https://github.com/open-cli-tools/concurrently in a separate PR? |
|
I don't really understand "too impactful". Who is impacted? |
|
To clarify, the impact I'm concerned about is on the broader ecosystem and the end users. While it’s completely understandable to introduce breaking changes in a major version bump, jsdom raising its minimum Node.js requirement practically means that many dependent projects will be forced to do the same. If this change were driven by an upgrade in jsdom's own core dependencies, it should be okay. Consequently, we might end up with a counterproductive situation where, contrary to our intent, nobody adopts the new jsdom version, and we just face unnecessary backlash. |
Update all direct dependencies to their current releases and refresh transitive resolutions in package-lock.json. Repeat the createTreeWalker Web IDL filter default in DocumentImpl for the @asamuzakjp/dom-selector 8 universal-selector path, which calls the implementation directly. Co-Authored-By: codex <codex@openai.com>
Indent the multiline flow sequence closing bracket so the stricter js-yaml 5 parser can load the WPT expectations file. Co-Authored-By: codex <codex@openai.com>
Pick up fixes for the selector regressions found while refreshing dependencies. Co-Authored-By: codex <codex@openai.com>
Raise the minimum supported Node.js version to exclude Node 20, and update all direct dependencies and transitive lockfile resolutions for the newer runtime floor.
Remove compatibility code that is no longer needed with the new Node.js and undici floors, including old undici handler adaptation, Node 20 ArrayBuffer.transfer fallbacks, direct minimatch usage for WPT expectations, and Node 20-only WPT skips.
The @asamuzakjp/dom-selector 8 universal-selector fast path calls the internal createTreeWalker implementation directly, bypassing the generated Web IDL default for its filter argument. Repeat that default in DocumentImpl so universal querySelectorAll() calls continue to return elements in tree order.