Skip to content

Bump Node.js floor and dependencies - #4170

Merged
domenic merged 4 commits into
mainfrom
bump-node-22-dependencies
Jul 20, 2026
Merged

domenic merged 4 commits into
mainfrom
bump-node-22-dependencies

Conversation

@domenic

@domenic domenic commented May 20, 2026 •

Copy link
Copy Markdown
Member

Raise the minimum supported Node.js version to exclude Node 20, and update all direct dependencies and transitive lockfile resolutions for the newer runtime floor.

Remove compatibility code that is no longer needed with the new Node.js and undici floors, including old undici handler adaptation, Node 20 ArrayBuffer.transfer fallbacks, direct minimatch usage for WPT expectations, and Node 20-only WPT skips.

The @asamuzakjp/dom-selector 8 universal-selector fast path calls the internal createTreeWalker implementation directly, bypassing the generated Web IDL default for its filter argument. Repeat that default in DocumentImpl so universal querySelectorAll() calls continue to return elements in tree order.

@domenic
domenic force-pushed the bump-node-22-dependencies branch from 7a22d7e to 2097b36 Compare May 20, 2026 03:39
@domenic
domenic marked this pull request as ready for review May 20, 2026 03:40
@domenic

domenic commented May 20, 2026

Copy link
Copy Markdown
Member Author

Seems like the failures are in dom/nodes/ParentNode-querySelector-All-dont-upstream.html on the fragment case, probably due to the dom-selector upgrade...

@domenic
domenic force-pushed the bump-node-22-dependencies branch from 2097b36 to 00ffcdf Compare May 20, 2026 08:25
@asamuzaK

Copy link
Copy Markdown
Contributor

Wouldn't it be better not to change the minimum support for v22 and v24?

@domenic

domenic commented May 20, 2026 •

Copy link
Copy Markdown
Member Author

Wouldn't it be better not to change the minimum support for v22 and v24?

It would be, but some of our dependencies / dev deps have higher minimums... Also some of them exclude v25, which I am not sure what to do about.

Edit: specifically, it's npm-run-all2@9.0.0 that is forcing this.

I guess I am OK with it because I generally prefer people be running the latest versions of things anyway, and only support older things because I want to respect the semver contract.

Update the minimum supported Node.js version to exclude Node 20 and refresh direct dependencies that now rely on newer runtimes.

Remove compatibility code that is no longer needed with the new Node and undici floors, including old undici handler adaptation, Node 20 ArrayBuffer.transfer fallbacks, direct minimatch usage for WPT expectations, and Node 20-only WPT skips.

Co-Authored-By: codex <codex@openai.com>
@domenic
domenic force-pushed the bump-node-22-dependencies branch from 00ffcdf to 2ea432e Compare May 20, 2026 09:04
@asamuzaK

Copy link
Copy Markdown
Contributor

I also agree with encouraging the use of the latest Node.js, but taking in this npm-run-all2 update feels too impactful considering where jsdom stands. Could we just stick with the current npm-run-all2 for now and maybe consider swapping to https://github.com/open-cli-tools/concurrently in a separate PR?

@domenic

domenic commented May 20, 2026

Copy link
Copy Markdown
Member Author

I don't really understand "too impactful". Who is impacted?

@asamuzaK

Copy link
Copy Markdown
Contributor

To clarify, the impact I'm concerned about is on the broader ecosystem and the end users.

While it’s completely understandable to introduce breaking changes in a major version bump, jsdom raising its minimum Node.js requirement practically means that many dependent projects will be forced to do the same.

If this change were driven by an upgrade in jsdom's own core dependencies, it should be okay.
However, this is just about one of the devDependencies.
From the users' perspective, it will appear as though Node.js support was dropped without any substantial reason.

Consequently, we might end up with a counterproductive situation where, contrary to our intent, nobody adopts the new jsdom version, and we just face unnecessary backlash.
Users aren't quick to upgrade Node, and they don't care about our view that staying on the latest version is the best practice.
I'm raising this because it's a lesson I learned from when we (me) bumped parse5 to a new major version.

domenic and others added 3 commits July 14, 2026 14:51
Update all direct dependencies to their current releases and refresh transitive resolutions in package-lock.json.

Repeat the createTreeWalker Web IDL filter default in DocumentImpl for the @asamuzakjp/dom-selector 8 universal-selector path, which calls the implementation directly.

Co-Authored-By: codex <codex@openai.com>
Indent the multiline flow sequence closing bracket so the stricter js-yaml 5 parser can load the WPT expectations file.

Co-Authored-By: codex <codex@openai.com>
Pick up fixes for the selector regressions found while refreshing dependencies.

Co-Authored-By: codex <codex@openai.com>
@domenic
domenic merged commit f32245c into main Jul 20, 2026
7 checks passed
@domenic
domenic deleted the bump-node-22-dependencies branch July 20, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants