refactor: optimize serialization function with modern JavaScript features #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures - Replaced string concatenation with template literals for better readability. - Simplified option validation using object maps for priority and sameSite. - Improved type safety with `instanceof Date` check for `expires` and added const assertions. - Enhanced sameSite handling for boolean values. - Removed unused isDate helper.
Ayoub-Mabrouk
force-pushed
the
chore/serialize
branch
from
cc00dac to
de5e15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: optimize serialization function with modern JavaScript features
instanceof Datecheck forexpiresand added const assertions.