Merge pull request #1267 from json-api-dotnet/fix-runtime-type-converter

maurei · web-flow · commit 6d49f71d1d5e · 2023-04-13T19:20:00.000+02:00
Use deterministic culture when converting to string
diff --git a/src/JsonApiDotNetCore.Annotations/Resources/Internal/RuntimeTypeConverter.cs b/src/JsonApiDotNetCore.Annotations/Resources/Internal/RuntimeTypeConverter.cs
@@ -46,7 +46,7 @@ public static class RuntimeTypeConverter
             return value;
         }
 
-        string? stringValue = value.ToString();
+        string? stringValue = value is IFormattable cultureAwareValue ? cultureAwareValue.ToString(null, cultureInfo) : value.ToString();
 
         if (string.IsNullOrEmpty(stringValue))
         {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public static class RuntimeTypeConverter`
`46`	`46`	`return value;`
`47`	`47`	`}`
`48`	`48`
`49`		`- string? stringValue = value.ToString();`
	`49`	`+ string? stringValue = value is IFormattable cultureAwareValue ? cultureAwareValue.ToString(null, cultureInfo) : value.ToString();`
`50`	`50`
`51`	`51`	`if (string.IsNullOrEmpty(stringValue))`
`52`	`52`	`{`