Skip to content

Use deterministic culture when converting to string #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

bkoelman
Copy link
Member

Although there's currently no code in JsonApiDotNetCore that uses RuntimeTypeConverter for converting to string, it's a public type. So its behavior should be deterministic and not depend on the OS-level culture settings.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1267 (d27b2f5) into master (9a2f364) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d27b2f5 differs from pull request most recent head db852cf. Consider uploading reports for the commit db852cf to get more accurate results

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         243      243           
  Lines        7814     7814           
=======================================
  Hits         7242     7242           
  Misses        572      572           
Impacted Files Coverage Δ
...tations/Resources/Internal/RuntimeTypeConverter.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman marked this pull request as ready for review April 13, 2023 12:01
@bkoelman bkoelman requested a review from maurei April 13, 2023 12:01
@maurei maurei merged commit 6d49f71 into master Apr 13, 2023
@maurei maurei deleted the fix-runtime-type-converter branch April 13, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants