Skip to content

Update many-to-many through PATCH on resource not working #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maurei opened this issue Apr 11, 2019 · 0 comments · Fixed by #496
Closed

Update many-to-many through PATCH on resource not working #494

maurei opened this issue Apr 11, 2019 · 0 comments · Fixed by #496

Comments

@maurei
Copy link
Member

maurei commented Apr 11, 2019 •
edited
Loading

Exactly same part of the spec as #492 but for many-to-many instead of one-to-many.

Currently creating relations in the simplest scenario works, as clarified by this test

More complex scenarios will fail. Eg, consider and article with tag_1

  • sending a patch with a new relationship to tag_2 (not including tag_1) results in having both. No complete replacement was performed
  • Similarly, when including both tag_1 and tag_2, it will try to recreate a relationship to tag_1, which will break
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 15, 2019
@maurei
test(json-api-dotnet#494): exposing bug with complete replacement
19a8935
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 15, 2019
@maurei
feat(json-api-dotnet#494): proper complete replace
5e330a8
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 15, 2019
@maurei
test(json-api-dotnet#494): distinguish between patch with and without…
c7add0e 
… overlap
@maurei maurei mentioned this issue Apr 15, 2019
Merged
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 15, 2019
@maurei
fix(json-api-dotnet#494): passing previous tests
457781c
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 15, 2019
@maurei
fix(json-api-dotnet#494): added another fix that also addresses an er…
89d55b6 
…ror in json-api-dotnet#492)
@maurei maurei mentioned this issue Apr 24, 2019
Closed
maurei added a commit to wisepotato/JsonApiDotNetCore that referenced this issue Apr 25, 2019
@maurei
Merge branch 'master' into feat/json-api-dotnet#494
b616f64
maurei added a commit that referenced this issue Apr 25, 2019
@maurei
Merge pull request #496 from wisepotato/feat/#494
fd96762 
Feat/#494
@maurei maurei mentioned this issue Apr 30, 2019
Closed
@maurei maurei mentioned this issue Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/#494 wisepotato/JsonApiDotNetCore
1 participant
@maurei