Consider simplifying constructor signatures in controller/repo/service layer

[wisepotato]

Its only needed here:

JsonApiDotNetCore/src/JsonApiDotNetCore/Controllers/BaseJsonApiController.cs

Lines 158 to 160 in 8570b21

	if (_jsonApiContext.Options.ValidateModelState && !ModelState.IsValid)
	return UnprocessableEntity(ModelState.ConvertToErrorCollection<T>(_jsonApiContext.ResourceGraph));

So.. we might be able to get rid of that.

[maurei]

Controller layer

• Remove ResourceGraph dependency in controller

Service layer

• Consider having a wrapping service to decrease size of constructors, allowing for easier extensibility
• Consider having internal constructors with signatures that allow for pipeline specific testing
• Consider splitting into smaller classes, see source

Repo layer

• remaining business logic has been removed from repository layer in Cleaning repository of remaining business logic #579

[maurei]

We could consider to do something like this.

Instead of

        public DefaultResourceService(
                ISortService sortService,
                IFilterService filterService,
                IIncludeService includeService,
                ISparseFieldsService sparseFieldsService,
                IPageService pageManager,
                IJsonApiOptions options,
                IResourceRepository<TResource, TId> repository,
                IResourceContextProvider provider,
                IResourceHookExecutor hookExecutor = null,
                ILoggerFactory loggerFactory = null)
        {
            _includeService = includeService;
            _sparseFieldsService = sparseFieldsService;
            _pageManager = pageManager;
            _options = options;
            _sortService = sortService;
            _filterService = filterService;
            _repository = repository;
            _hookExecutor = hookExecutor;
            _logger = loggerFactory?.CreateLogger<DefaultResourceService<TResource, TId>>();
            _currentRequestResource = provider.GetResourceContext<TResource>();
        }

public DefaultResourceService(IEnumerable<IQueryParameterService> queryServices,  ....)

we could do

        public DefaultResourceService(
                IEnumerable<IQueryParameterService> queryParameters
                IJsonApiOptions options,
                IResourceRepository<TResource, TId> repository,
                IResourceContextProvider provider,
                IResourceHookExecutor hookExecutor = null,
                ILoggerFactory loggerFactory = null)
        {
            _includeService = queryParameters.Single(qp => qp is IIncludedService);
            _sparseFieldsService =  queryParameters.Single(qp => qp is ISparseFieldsService);
            _pageManager =  queryParameters.Single(qp => qp is IPageService);
            _sortService =  queryParameters.Single(qp => qp is ISortService);
            _filterService =  queryParameters.Single(qp => qp is IFilterService);
            _repository = repository;
            _options = options;
            _hookExecutor = hookExecutor;
            _logger = loggerFactory?.CreateLogger<DefaultResourceService<TResource, TId>>();
            _currentRequestResource = provider.GetResourceContext<TResource>();
        }

This would allow for a more extensibility and future features without having to introduce breaking changes