Fixed: Produce error on invalid ID in request body #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
+ Coverage 90.80% 90.85% +0.04%
==========================================
Files 348 348
Lines 11185 11189 +4
Branches 1836 1838 +2
==========================================
+ Hits 10157 10166 +9
+ Misses 676 672 -4
+ Partials 352 351 -1 ☔ View full report in Codecov by Sentry. |
| Method | Mean | Error | StdDev | Ratio | Allocated | Alloc Ratio |
|------------------------ |---------:|---------:|---------:|------:|----------:|------------:|
| ActivatorCreateInstance | 84.13 ms | 4.029 ms | 1.046 ms | 1.00 | 69 B | 1.00 |
| LookupCached | 67.93 ms | 0.345 ms | 0.053 ms | 0.81 | 7 B | 0.10 |
```c#
using System.Collections.Concurrent;
using BenchmarkDotNet.Attributes;
namespace Benchmarks;
// ReSharper disable once ClassCanBeSealed.Global
[MarkdownExporter]
[SimpleJob(1, 5, 5)]
[MemoryDiagnoser]
public class DefaultValueBenchmarks
{
private const int IterationCount = 10_000_000;
private static readonly ConcurrentDictionary<Type, object?> Cache = new()
{
[typeof(int?)] = null,
[typeof(Guid?)] = null
};
[Benchmark(Baseline = true)]
public void ActivatorCreateInstance()
{
for (int index = 0; index < IterationCount; index++)
{
_ = Activator.CreateInstance(typeof(int?));
_ = Activator.CreateInstance(typeof(Guid?));
}
}
[Benchmark]
public void LookupCached()
{
for (int index = 0; index < IterationCount; index++)
{
_ = Cache.TryGetValue(typeof(int?), out _);
_ = Cache.TryGetValue(typeof(Guid?), out _);
}
}
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where an empty string or whitespace for
idis incorrectly accepted in a request body whenTIdis notstring.The behavior of
RuntimeTypeConverterremains unchanged (due to potential impact). The check is implemented in the deserialization of incoming request bodies.Test coverage for the three modes of
ClientIdGenerationModehas improved. Tests for all endpoints usingstringasTIdwere added. These use a single space, because an empty string results in a broken experience: you can't get-by-id, delete, or update such a resource, and rendered links are unusable.Additionally, this PR makes a type's default value lookup 20% faster and reduces allocations by 90% (see commit message for details).
Fixes #1485.
QUALITY CHECKLIST